I would recommend you go with the KYB's that Steve has suggested, if on a budget.
KYB actually manufacture the standard shocks for Subaru.
The knocking is caused by the angle of the shock (it's not vertical), which causes the insert to wear un-evenly and also the grease going hard within it.
|